<< Back to previous view

[PCC-173] different i386-specific features use the same SLOCAL flag bit Created: 15/Oct/10  Updated: 01/May/14

Status: Closed
Project: pcc
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Iain Hibbert Assignee: Anders Magnusson
Resolution: Won't Fix Votes: 0
Environment: pcc/i386

File Attachments: File slocal.diff    

 Description   
Hi,
   in arch/i386/macdefs.h the following appears

/*
 * i386-specific symbol table flags.
 */
#define SSECTION SLOCAL1
#define STLS SLOCAL2
#define SSTDCALL SLOCAL2
#define SDLLINDIRECT SLOCAL3

which means that STLS and SSTDCALL can be confused in the codebase as both use SLOCAL2.

Since there are only 3 flags allocated for arch-specific features, and SSECTION is not actually used, the attached patch fixes this by removing SSECTION and using SLOCAL1 for STLS.


 Comments   
Comment by Anders Magnusson [ 16/Oct/10 03:41 PM ]
stdcall do not work on i386, some other changes are needed to be happy with it.
Besides that, STLS and SSTDCALL are used on different symbols; tls on variables and stdcall on functions, so there should not be any ambiguity.
Comment by Anders Magnusson [ 01/May/14 05:54 PM ]
The specific thing in the ticket is not a problem.
Generated at Wed Sep 17 09:34:30 CEST 2014 using JIRA Enterprise Edition, Version: 3.13.1-#333.